Client sampling and roots capabilities set to None if not implemented #802
+181
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ihrpr I think this is an important PR to make sure the SDK adheres to the protocol. |
| roots = None | ||
| else: | ||
| roots = types.RootsCapability( | ||
| # TODO: Should this be based on whether we |
There was a problem hiding this comment.
The spec says:
When roots change, clients that support listChanged MUST send a notification:
So I guess it would be the former.
There was a problem hiding this comment.
Totally agree!
This TODO comment was already in the code base, I just kept it...
I only added the if-else structure around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now clients always claims to support sampling and roots capabilities, which is inaccurate.
Having this properly set allows servers to fallback to alternative implementations.
Motivation and Context
Servers might rely on the correctness of client capabilities, so clients should inform them accurately.
How Has This Been Tested?
Unit tests
Breaking Changes
No
Types of changes
Checklist
Additional context